Skip to content

Moves case studies from Private Key section to a dedicated section - #161

Merged
GBKS merged 5 commits into
masterfrom
feature/extract-case-studies
Mar 8, 2021
Merged

GBKS merged 5 commits into
masterfrom
feature/extract-case-studies

Conversation

@GBKS

@GBKS GBKS commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

Also splits the four case studies into dedicated pages.

No changes were made to the case study content. Only addition was a landing page that lists the case studies and has a short description for each one.

I find this helpful to get a feel for what we already have in terms of case studies, what seems missing, etc.

Also splits the four case studies into dedicated pages.
@GBKS GBKS added the Copy Task is about improving text. label Feb 24, 2021
@GBKS GBKS linked an issue Feb 24, 2021 that may be closed by this pull request
@GBKS
GBKS marked this pull request as ready for review March 3, 2021 11:11
@GBKS
GBKS requested a review from danielnordh March 3, 2021 11:11
Added case studies to the guide overview page.
Revised case studies intro paragraph (was still copy/pasted from the private key section).
@pavlenex

pavlenex commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

Looks a bit weird without the nesting imo. The terminology isn't really self-explanatory and as case-study grows it'll be hard to distinguish perhaps what's connected to what.
For example, one might expect that the Multisig wallet is a case study about multisig wallets, but it's more focused on private key management aspect of it.

Screenshot from 2021-03-04 11-25-13

@GBKS

GBKS commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

@pavlenex there is nesting. Is is too subtle to see?

Agree about the naming, that needs to be clarified without becoming super long. We have to keep in mind though that this is navigation, and that people can go to the "Case study" landing page for longer descriptions. So this short nav item doesn't have to cover everything (should be more precise than it currently is though).

@pavlenex

pavlenex commented Mar 4, 2021 •

Copy link
Copy Markdown
Contributor

@GBKS I mean, as we add stuff, it probably should to be categorized.

  • Case Studies
    • Private Key Management
      - Cloud
      - Multisig
      - Upgradable
      - Shared
    • Another category

@GBKS GBKS added this to the Sprint #1 milestone Mar 4, 2021
@GBKS GBKS self-assigned this Mar 4, 2021
@GBKS

GBKS commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

@pavlenex got it, let's tackle that separately. I'll add two-level nesting as a new issue as we don't have that functionality yet. I'm also wondering if we won't have overlap between case studies - there might be one that deals with both onboarding, private keys and accessibility, for example. Not sure how we'd organize that.

@danielnordh

Copy link
Copy Markdown
Contributor

Looks good to me. Minor comments:

  • Titles of the case studies (intro page, nav bar) should probably match up with the subpages
  • PR Create unified Bitcoin design principles page #144 has a link to the existing case studies page in the 'Shared schemes' page that will need to be changed if this merges first (easy to do)

@danielnordh danielnordh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, approved.


{% include prototype.html
link = "https://www.figma.com/proto/SRWlaxbDulsacpPQn2TTri/Case-study-prototypes?node-id=1%3A3&viewport=1357%2C576%2C1&scaling=scale-down"
image = "/assets/images/guide/case-studies/case-cash.png"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be for another PR and I think it's been mentioned before, but should we start using SVG's instead so we can simplify and use one image now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. We should do a review of this across the whole guide before we go live with V1.

@GBKS
GBKS merged commit 2adca8d into master Mar 8, 2021
@danielnordh
danielnordh deleted the feature/extract-case-studies branch May 11, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a landing page for a new case studies section

4 participants