Repository navigation
Create unified Bitcoin design principles page - #144
Merged
Merged
Conversation
pavlenex
reviewed
Feb 12, 2021
pavlenex
left a comment
Contributor
There was a problem hiding this comment.
Solid list and principles. Some early light feedback.
danielnordh
marked this pull request as ready for review
February 12, 2021 11:30
GBKS
reviewed
Feb 15, 2021
GBKS
reviewed
Feb 15, 2021
GBKS
reviewed
Feb 15, 2021
GBKS
reviewed
Feb 15, 2021
GBKS
reviewed
Feb 15, 2021
GBKS
reviewed
Feb 15, 2021
Co-authored-by: Christoph Ono <chri@sto.ph>
…/Guide into feature/principles
pavlenex
reviewed
Mar 22, 2021
pavlenex
left a comment
Contributor
There was a problem hiding this comment.
I did a final look at the content in-depth. Structure-wise, great work, and I think you included the most important principles and emphasized their importance.
I've suggested a few minor typos and grammar-related fixes I've noticed, as well as 2-3 attempts to simplify the structure of the sentence, which is up to you to accept or ignore, it's just a personal preference.
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
pavlenex
approved these changes
Mar 24, 2021
pavlenex
left a comment
Contributor
There was a problem hiding this comment.
tACK.
This one is good to get merged IMO 🚀
Contributor
|
tACK. Two small follow-up tasks I can think of:
|
Contributor
|
@danielnordh @GBKS For the follow-up tasks, if you'd like we can open a separate issue to keep a track of it. 🚀 🚀 |
This was referenced Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new page for unified principles following issue #116.
Todo: