Skip to content

Drop the healthcheck's DAC_OVERRIDE requirement #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MYDIH wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop the healthcheck's DAC_OVERRIDE requirement #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion build/go/socket-proxy/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,25 @@ func httpProxy(w http.ResponseWriter, r *http.Request){
}
}

func healthcheck(exit bool){
func healthcheck(exit bool) {
// unprivileged user
proxyUID, err := strconv.Atoi(uid)
if err != nil {
eleven.LogFatal("SOCKET_PROXY_UID must be a number %v", err)
}
proxyGID, err := strconv.Atoi(gid)
if err != nil {
eleven.LogFatal("SOCKET_PROXY_GID must be a number %v", err)
}

// Using a privileged user to access an unprivileged socket would require DAC_OVERRIDE
if err := syscall.Setgid(proxyGID); err != nil {
eleven.LogFatal("could not set GID to %d %v", proxyGID, err)
}
if err := syscall.Setuid(proxyUID); err != nil {
eleven.LogFatal("could not set UID to %d %v", proxyUID, err)
}

healthcheckSockerDialer := &net.Dialer{Timeout: 2*time.Second}
socket, err := healthcheckSockerDialer.Dial("unix", socketProxy)
if err != nil {
Expand Down