Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
In the process of hardening my stack, I dropped all capacities on this tool, only enabling the ones needed. While CHOWN, SETUID, SETGID makes sense considering what the container is doing, DAC_OVERRIDE feels less required. It is needed for now since the healthcheck is trying to access the unprivileged socket using the image user (which is root:docker comonly vs 1000:1000).
This fix also drops to the unprivileged user on the healthcheck path to allow the removal of the DAC_OVERRIDE capability
After the fix, an hardened compose snippet could look like
Thx