Skip to content
This repository was archived by the owner on May 16, 2026. It is now read-only.

Fix major mistake in the README. - #7

Merged
zware merged 1 commit into
zware:mainfrom
ezio-melotti:patch-1
Aug 21, 2022
Merged

zware merged 1 commit into
zware:mainfrom
ezio-melotti:patch-1

Conversation

@ezio-melotti

Copy link
Copy Markdown
Contributor

Don't merge this just yet.
I want to see what happens when I delete my fork.

@ezio-melotti ezio-melotti closed this by deleting the head repository Aug 21, 2022
@ezio-melotti

ezio-melotti commented Aug 21, 2022 •

Copy link
Copy Markdown
Contributor Author

Looks like the PR got closed, but the changes are still available, and there is a "Reopen and comment" button too.

@zware can you reopen the PR and see what happens?

Are you able to push changes to the branch?

@zware

zware commented Aug 21, 2022

Copy link
Copy Markdown
Owner

Reopen appears to be an option.

@zware zware reopened this Aug 21, 2022
@zware

zware commented Aug 21, 2022

Copy link
Copy Markdown
Owner

I'm not sure if I can push to the branch, but I'm only on a phone yet this morning.

Comment thread README.md
@@ -1,2 +1,2 @@
# test
Test repository. Not for testing.
Test repository. For testing.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Test repository. For testing.
Test repository. For not testing.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't appear to be able to commit this suggestion, so it may be that I can only merge it as is rather than being able to update. Will try from a real checkout.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't appear to have any way to push to this branch, though gh pr checkout was able to check it out.

@zware
zware merged commit eedb107 into zware:main Aug 21, 2022
@zware

zware commented Aug 21, 2022

Copy link
Copy Markdown
Owner

Merging worked as expected, even though the fork is gone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants