Repository navigation
ci(linux): skip the Vulkan probe with the smoke it guards - #31
Merged
Merged
Conversation
Under TRACE_CI_RUNNERS=self-hosted the Linux leg skips the DesktopVK smoke because it crashes on llvmpipe, but still ran vulkaninfo under Xvfb. The probe intermittently fails to open the same X display ("XCB failed to connect", AppCreateXcbSurface), failing the job after every test passed. Guard the probe with the same flag so the Vulkan tooling stays on hosted CI only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Under
TRACE_CI_RUNNERS=self-hosted, the Linux leg deliberately skips the MonoGame DesktopVK smoke (it crashes on llvmpipe over Xvfb), but it still runs:On the self-hosted Ubuntu runner that probe intermittently fails to open the X display:
The job then fails after all unit, XAML, catalog, quick-start, render and SVG steps passed. This is what failed the
mainpush run after the pointer-trace merge (run 43885594142) and the previousmainrun.Change
Move the probe inside the existing
if [[ -z "${FORMA_SKIP_VULKAN_SMOKE:-}" ]]block, alongside the DesktopVK smoke it is there to describe. Hosted CI still runs the probe and both Vulkan smokes; the self-hosted fleet, which cannot run either, skips all three.No product code changes.