Skip to content

do not check for java executable file in JAVA_HOME - #100

Merged
playdohface merged 1 commit into
zed-extensions:mainfrom
playdohface:86-remove-check-for-java-executable-in-java-home
Oct 20, 2025
Merged

playdohface merged 1 commit into
zed-extensions:mainfrom
playdohface:86-remove-check-for-java-executable-in-java-home

Conversation

@playdohface

Copy link
Copy Markdown
Collaborator

because we can't see it anyway

@cla-bot cla-bot Bot added the cla-signed label Oct 20, 2025
@playdohface
playdohface merged commit b65fa10 into zed-extensions:main Oct 20, 2025
1 check passed
@tartarughina

Copy link
Copy Markdown
Collaborator

@playdohface I think to have found a workaround for fs operations. By leveraging worktree.which() I was able to see whether a file exists or not. @MrSubidubi how hacky is this approach?

@MrSubidubi

Copy link
Copy Markdown
Contributor

@tartarughina Well, definitely not too intended, but looking into it deeper, it somewhat makes sense that it works. I think it would be fine? If you find it works, feel free to pursue a bit in that direction.

@playdohface

Copy link
Copy Markdown
Collaborator Author

@tartarughina are you doing worktree.which("/fully/qualified/path") == "/fully/qualified/path" to achieve that? I'm not against it if we know it works cross-platform.

@tartarughina

Copy link
Copy Markdown
Collaborator

No, I use the relative path. As you shared in a different comment this is the intended Unix which behavior. It looks not only in the $PATH but also in the current working directory.

Which returns a result so if the result is Some the file exists and you can do operations based on it.
I don't remember if I've tested it also with an absolute path and what was the outcome.
I need to further test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants