Skip to content

feat(code-review-kit): add code review, conventional commits and PR description plugin - #140

Open
ajaycanvas wants to merge 1 commit into
zai-org:mainfrom
ajaycanvas:add-code-review-kit
Open

ajaycanvas wants to merge 1 commit into
zai-org:mainfrom
ajaycanvas:add-code-review-kit

Conversation

@ajaycanvas

Copy link
Copy Markdown

Plugin type (required) / 插件类型(必填)

  • UI Plugin / 是 UI 插件 — provides MCP Apps interactive pages / 提供 MCP Apps 交互页面
  • Standard plugin / 普通插件(非 UI) — does not provide MCP Apps interactive pages / 不提供 MCP Apps 交互页面
  • Not applicable / 不适用 — repository-only changes; no plugin content changed / 仅仓库级改动,不涉及插件内容

Affected plugin name(s) / 涉及的插件名称:code-review-kit

What / 改动内容

Adds code-review-kit (v0.1.0), a standard plugin under external_plugins/code-review-kit/ and registered in marketplace.json under developer-tools.

The plugin turns the agent itself into the reviewer — no API keys, no external services, no MCP server, no runtime dependencies (pure skills + slash commands on local git diffs):

  • /review — severity-grouped diff review (🔴 correctness/security, 🟡 reliability/perf/tests, 🔵 maintainability), reads full files and callers rather than judging hunks in isolation, ends with a merge verdict. Also available as the auto-triggering code-review skill.
  • /commit — Conventional Commits message derived from the staged diff, with secret and debug-leftover checks before committing.
  • /pr — copy-ready PR title and body (summary, changes by area, testing steps, risks) from the branch diff.

Bilingual: README.md + README_CN.md, description_i18n with en/zh-CN in manifest and marketplace entry, example prompts in both languages. Reports follow the conversation language.

Model/API/network dependencies: none beyond the host agent session — diffs are read locally via git; the plugin performs no network calls of its own (documented in the READMEs' privacy sections).

Self-check / 自查清单

  • Plugin name is unique kebab-case; new external plugin directory is external_plugins/<name>/; existing fixes retain ownership / 插件名唯一且 kebab-case,外部新增插件位于 external_plugins/<name>/,已有插件修复保留原归属
  • Usage category is set independently of publisher ownership / 用途分类 category 已填写,与维护归属分开
  • Plugin type and affected names are declared above / 已在上方声明插件类型与涉及的插件名称
  • version bumped in BOTH plugin.json and marketplace.json (artifacts are immutable) / plugin.json 与 marketplace.json 两处版本号已同步升级(制品不可变)— new plugin, 0.1.0 in both
  • README.md (EN) and README_CN.md (中文) both updated and equivalent / 中英文 README 均已更新且语义一致
  • description_i18n has both en and zh-CN / description_i18n 包含 en 与 zh-CN
  • No secrets, machine-specific paths, or private dependencies / 不含密钥、机器专属路径或私有依赖
  • Model/API/network dependencies documented / 模型、API、网络依赖已写明
  • python3 scripts/validate.py and python3 scripts/build_dist.py pass locally / 本地校验与构建均通过

Note on the build check: validate.py passes for all 53 plugins. build_dist.py builds code-review-kit cleanly (verified by calling the script's own build_zip — 8 files, correct tree), but on a fresh clone the script exits early at excalidraw (a UI plugin requiring pnpm build output that is not committed), before and independent of this change. No changes to UI plugins or build infrastructure are part of this PR.

@panda920

Copy link
Copy Markdown
Collaborator

❌ Internal validation failed:

FAIL: 1 problem(s)
  - marketplace.json plugins[52] (code-review-kit): plugin.json description_i18n does not match marketplace entry

Please fix it and push again; the check re-runs automatically.

🤖 Copy this prompt into Claude Code / Codex to fix it
You are updating my pull request #140 to github.com/zai-org/zcode-plugins (the ZCode plugin marketplace).
The maintainers' automated intake reported: `python scripts/validate.py` failed

Validator output:
FAIL: 1 problem(s)
  - marketplace.json plugins[52] (code-review-kit): plugin.json description_i18n does not match marketplace entry

Fix it in this repository:
- New external plugins belong under external_plugins/<my-plugin>/; keep existing plugins in their current directory;
  never modify .github/, scripts/, tests/, .gitignore, .gitattributes or AGENTS.md.
- Follow CONTRIBUTING.md and AGENTS.md: the manifest lives at <plugin-directory>/.zcode-plugin/plugin.json,
  its name/version must match marketplace.json, names are kebab-case, keep the required i18n fields.
- Fetch the latest main of zai-org/zcode-plugins and rebase onto it; if marketplace.json conflicts,
  keep every existing entry and re-add mine.
- Run `python scripts/validate.py` until it passes, then force-push my PR branch.

@panda920

Copy link
Copy Markdown
Collaborator

✅ Internal validation passed. A ZCode maintainer will review the change next; after acceptance, release checks run separately and this PR is closed automatically.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants