This repository was archived by the owner on May 22, 2025. It is now read-only.
Repository navigation
Removes old PDAs - #22671
Merged
ToasterBiome merged 10 commits intoOct 13, 2024
Merged
Removes old PDAs#22671
Conversation
Contributor
A new console function is not needed since PDAs can set their username to anything they like, all the syndicates need is access to PDAs |
Contributor
|
I knew this day would come |
AMyriad
approved these changes
Oct 5, 2024
AMyriad
left a comment
Contributor
There was a problem hiding this comment.
+1 rep decluttered hop offices
Yogbot-13
added a commit
that referenced
this pull request
Oct 10, 2024
This was referenced Oct 11, 2024
ynot01
previously requested changes
Oct 11, 2024
ynot01
left a comment
Contributor
There was a problem hiding this comment.
Undo whatever you did to the PDA painters, I will make them work with new PDAs (biome approved)
JohnFulpWillard
marked this pull request as draft
October 12, 2024 01:35
updates pda painter to work with new pdas
JohnFulpWillard
marked this pull request as ready for review
October 12, 2024 18:22
Yogbot-13
added a commit
that referenced
this pull request
Oct 13, 2024
This was referenced Nov 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Why is this good for the game?
old PDAs are nearly completely unused and the few places they are used barely function, faking messages is utterly useless to anyone that isn't a pAI, and said pAI would then just immediately question why they are getting a PDA message when there's no way to obtain one in-game.
This is all just very messy and fucked up so it's better to remove them and start better support for the new PDAs in the future instead.
Testing
Tested pAIs buying and using their new PDA
Tested pAIs using their signaler cause I messed with that
Tested changing people's names as Admin to ensure PDAs were renamed as well
Tested PDA painters on PDAs and phones.
Not really much else to test since basically everything else is removal.
Changelog
🆑 JohnFulpWillard & ynot01
rscdel: Removed old PDAs and the ability to fake messaging with the telecomms messaging monitor console.
tweak: PDA painters now work with new PDAs and phones.
tweak: pAIs now use new PDAs.
/:cl: