This repository was archived by the owner on May 22, 2025. It is now read-only.
Repository navigation
Should fix cloning and dna based appearance weirdness I.E. changing the appearance of an empty clone changes YOUR appearance - #22248
Merged
Conversation
Moltijoe
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Clone disks and scans were saving direct references to your DNA's identity and feature blocks. So changes impacting them, also impacted the scanned body.
now it just saves the string instead of the actual reference variable
Why is this good for the game?
No more worrying that a clone lying around with your DNA can randomly impact you. However radiation and stuff can still change your appearance so maybe i'll do something about that eventually
Testing
let me know if clones end up coming out more accurate than they should. Mqiib was saying some aspects like eye color were supposed to be different
Changelog
🆑 thanks for the help @TehLadyK
bugfix: cloning scans and disks no longer hold a direct reference to your DNA appearance attributes
/:cl: