This repository was archived by the owner on May 22, 2025. It is now read-only.
Repository navigation
Reduce dynamic weight to 0 - #22136
Merged
ToasterBiome merged 1 commit intoJun 2, 2024
Merged
Conversation
github-actions
Bot
added
the
Config
ToasterBiome
approved these changes
Jun 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this good for the game?
Dynamic has not only basic issues
-overly complicated
-bug prone
But it doesn't even get close to solving the problem it attempts to solve because we don't commit to it 100%
having both it and gamemodes results in us flip flopping between traitor and dynamic,
this ends up with us just always having traitor as dynamic is almost always going to be traitor at this pop
in a sense, it makes the problem worse
anyways, it's not in a state that's worth committing 100% to
Spending dev time to make it good makes little sense when it'd be better for the longrun to port monke storytellers
I do not have permission to port monke storytellers for the time being
i considered removing it from the code outright, but until we have an alternative, i'm sure biome would want me to keep it for the downstreams
so disabling dynamic is the best course of action in my mind
Testing
number change innit
🆑
rscdel: Disables dynamic
/:cl: