Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

New Station Activity: Shipbreaking - #22030

Merged
ToasterBiome merged 18 commits into
yogstation13:masterfrom
cowbot92:shipbreaker
May 16, 2024
Merged

ToasterBiome merged 18 commits into
yogstation13:masterfrom
cowbot92:shipbreaker

Conversation

@cowbot92

@cowbot92 cowbot92 commented May 12, 2024 •

Copy link
Copy Markdown
Contributor

Document the changes in your pull request

This will allow crew members to call in, and break down ships for resources, research points, goodies, and possibly more. For now this will be a box(tm) specific feature, but if enough people like it I'll map it to other maps. This will replace the useless podbay

Lore: These scrapped ships being available to be scrapped is because NT invested a bunch of money into dredging up these ships from various places to fix up and repair them codenamed “shiptest” and then the guy in charge of the project got laid off and they cut the program so now there’s the new program "Shipbreaker"

Why is this good for the game?

Gives people without specific set jobs something to do over the shift, or parts of it. Not focused on sec/antag gear but still rewarding.

Testing

shipbreaker.mp4

Area where you'll go to begin ship breaking
image

image

Ship Designs
Syndicate Prison Transport

image

NT Med Transport

image

Old Robotics Transport

image

Wiki Documentation

Wiki please reach out to me

Changelog

🆑 Cowbot92 & Chubbygummibear
rscadd: Adds new station side activity: Shipbreaking
wip: This is work in progress, feel free to comment ideas & ship "themes" or make your own for me to add
mapping: Removes the box podbay
experimental: This is very experimental
/:cl:

@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game labels May 12, 2024
@Beeper-Skeeper

Copy link
Copy Markdown
Contributor

OH
I GET IT NOW
THIS SHIT LOOKS FIRE

@github-actions github-actions Bot added the Mapping Will result in a change to a map. label May 12, 2024
@AMyriad

AMyriad commented May 12, 2024

Copy link
Copy Markdown
Contributor

I really really like this idea, and yet I have a really big gripe with making this something that'd spawn stationside and give the public access to EVA equipment, or easily-stealable-by-hacking EVA equipment. I really believe it'd be best to make this a cargo job, rather than relegating it to the makeshift shipbreaking brigade of assistants. Assistants and engineers, because I can't think of anyone else who'd go out and disassemble ships.

I don't want to be a negative nelly here cause love the idea and I respect the work you're doin, but this could be better implemented than a podbay replacement of all things.

@wonderinghost

Copy link
Copy Markdown
Contributor

I really really like this idea, and yet I have a really big gripe with making this something that'd spawn stationside and give the public access to EVA equipment, or easily-stealable-by-hacking EVA equipment. I really believe it'd be best to make this a cargo job, rather than relegating it to the makeshift shipbreaking brigade of assistants. Assistants and engineers, because I can't think of anyone else who'd go out and disassemble ships.

I don't want to be a negative nelly here cause love the idea and I respect the work you're doin, but this could be better implemented than a podbay replacement of all things.

Could have this be like the miners conscription kit. Or possibly make up a bunch of jobs (unlisted) with their own set of accesses within departments.

Also you could just move pod area over to where custom shuttle resources are

@wonderinghost

Copy link
Copy Markdown
Contributor

Oh yeah you were asking for ship ideas.

The galaga ship could be one

@drderp3635

Copy link
Copy Markdown

I would add floors to the docking area like the dock on the mining outpost, so assistants can scrap without needing spacesuits.

@github-actions github-actions Bot added the tgui This PR affects TGUI label May 13, 2024
@cowbot92
cowbot92 marked this pull request as ready for review May 13, 2024 21:50
@cowbot92
cowbot92 requested a review from a team as a code owner May 13, 2024 21:50

@ToasterBiome ToasterBiome left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the ships should use turf/template_noop instead of space too

Comment thread yogstation/code/modules/shipbreaker/shipbreaker.dm Outdated
Comment thread yogstation/code/game/objects/effects/landmarks.dm Outdated
@cowbot92

Copy link
Copy Markdown
Contributor Author

All of the ships should use turf/template_noop instead of space too

Updated

@cowbot92
cowbot92 requested a review from ToasterBiome May 13, 2024 22:06
Yogbot-13 added a commit that referenced this pull request May 15, 2024
@wonderinghost

Copy link
Copy Markdown
Contributor

this reminds me, got to do a bounty or work on updating the recycler so it checks the recipe, so everything doesnt produce just glass and iron

Yogbot-13 added a commit that referenced this pull request May 15, 2024

@ToasterBiome ToasterBiome left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map review:

fix the recycler in disposals
make sure any windows have plating under them, not reinforced floor

@cowbot92

Copy link
Copy Markdown
Contributor Author

map review:

fix the recycler in disposals make sure any windows have plating under them, not reinforced floor

fixed and ship windows adjusted

@cowbot92
cowbot92 requested a review from ToasterBiome May 16, 2024 03:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Mapping Will result in a change to a map. tgui This PR affects TGUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants