This repository was archived by the owner on May 22, 2025. It is now read-only.
Repository navigation
Fixes quirks STILL being reset randomly along with jobs + reverts 21541 and partially 21653 - #21714
Merged
Merged
Conversation
Yogbot-13
added a commit
that referenced
this pull request
Mar 23, 2024
This was referenced Nov 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
I was thinking too hard about this. If quirks don't exist, we simply load them.
My solution was overblown and stopped players from accessing their characters arbitrarily.
Should also stop jobs being exploded because of an unloaded character.
Ports tgstation/tgstation#61492
Testing
Changelog
🆑
bugfix: quirks should finally stop resetting for real, along with your jobs since your character is loaded properly.
/:cl: