This repository was archived by the owner on May 22, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on May 22, 2025. It is now read-only.
Incorrect lumen calculation in some cases #17519
Description
Severity
Inconvenience
Short Description
Incorrect lumen calculation in some cases
Reproduction
Supposedly podpeople struggle on lavaland because they do not get enough light, even though they should have enough
Round ID
Any
Test Merges
No response
BYOND Username
No response
Was this done on a locally hosted or non-Yogstation hosted server?
None
Additional information
No response
Activity
GraveHat commentedon Jan 16, 2023
Note that moving to pre-existing light sources stops them from dying, but turning your light off and on again after getting the message does not. In-game this feels more like the system is lagging behind the player constantly moving but standing still after getting the notification does not seem to stop the suffocation as it still counts as dark.
The forewarning notification Pod people get that warns them that there's not much light in the area will be seen frequently while simply walking around before getting immersed in total "Darkness."
ThatLing commentedon Feb 12, 2023
After some investigating, it seems like some turfs don't have their lighting corners set (e.g.
lighting_corner_NE). This happens in/datum/light_source/proc/update_cornerswhich is called from SSlighting fire.ThatLing commentedon Feb 12, 2023
Disregard this, the corners are for static lighting.
turf.dynamic_lumcountis used for dynamic lighting, maybe it's just not high enough?Oblisk234 commentedon Nov 13, 2024
Was fixed by #21221.