Repository navigation
ci: release with release-please, pinning the image on the release PR - #16
Merged
Merged
Conversation
action.yml pins the image by digest, and a tag cannot carry the digest of an image its own push builds, so publish-image.yml needed two tags per release. The Release workflow now builds the image on the release PR and commits its digest there (signed, via createCommitOnBranch). Merging the PR creates vX.Y.Z; publish tags the pinned digest X.Y.Z and X without rebuilding, smoke tests it, and moves the git tag vX. pin-image runs on every push to main and merges main into the release branch first, since release-please leaves its branch alone for hidden-type commits such as dependency bumps. The image carries an org.opencontainers.image.revision label, and publish refuses to tag unless that commit matches the release commit outside action.yml. release-as 7.0.0 forces the first release (the Node 26 bump is a build: commit) and must be removed once v7.0.0 is out. bootstrap-sha is v6.3.1, as the repo has no GitHub Releases for release-please to anchor to. Removes publish-image.yml and commit-and-tag-version with its .versionrc.json and action.yml updater, which the digest pin had already broken, and conventional-changelog-cli. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the tag-triggered
publish-image.ymlandcommit-and-tag-versionwith release-please, following the setup used in record-action, unifi-mcp and thesync-lockfilerepos. Design and alternatives are indecisions/2026-11-11-release-please-pins-image-on-release-pr.md..github/workflows/release.ymlhas three jobs:SEMANTIC_RELEASE_APP_*, scoped to this repo),noderelease type, so it bumpspackage.jsonandpackage-lock.json.autorelease: pending) is open, mergesmaininto its branch via the update-branch API if needed, builds the image with anorg.opencontainers.image.revisionlabel, pushes it as:release-pr, and commits the digest toaction.ymlon the branch withcreateCommitOnBranch(signed, forrequired_signatures). It skips when the branch already containsmainand ends in a pin commit.release_created, fails unless the release commit changedaction.ymland the pinned image's revision matches the release commit outsideaction.yml. It then tags the pinned digestX.Y.ZandXwithdocker buildx imagetools create(no rebuild), smoke tests it, and moves the git tagvX.Config:
release-as: 7.0.0forces the first release: everything since v6.3.1, including the Node 26 bump (build: run the action on node 26.13.0 #15, abuild:commit), is a type release-please does not release. It has to be removed after v7.0.0 ships.bootstrap-shais v6.3.1's commit, since the repo has no GitHub Releases to anchor to.buildcommits appear in the changelog as "Build System"; other types follow unifi-mcp.Removed:
publish-image.yml,.versionrc.json,.github/tasks/actionYamlUpdater.js(which threw on the digest pin), thechangelogscript, and thecommit-and-tag-versionandconventional-changelog-clidev dependencies (139 lockfile entries, no other package versions changed). Theci.ymlcomment and.eslintrc.jsonignore that referenced them are updated.Checked locally:
jactionlint --online,prek run, and on Node 26.13.0npm ci,npm test(39 passing),npm run build,npm run lint. The digestsed/yqhandling and the source-matchgit diffwere run against test inputs. The workflow itself has not run yet; it first runs when this merges.🤖 Generated with Claude Code