Repository navigation
Conversation
…es no URL dependency for a library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WINDOWKIT.mdand the release workflow said a dependent names the tarball's URL. That holds for an application and not for a published library: npm 12 defaultsallow-remoteandallow-gittonone, an application can allow its own withallow-remote=root, and a library's dependency is a dependency of a dependency to whoever installs it.ntk 8.17.2 depended on the tarball and could not be published: its publish job failed in
npm ciwithEALLOWREMOTE. ntk goes back to fontkit from npm and does the work itself in sidorares/ntk#485, so nothing depends on this fork now.Also moves the workflow's two actions from v4 to v7, which ntk uses, since v4 ran with a Node 20 deprecation warning. The workflow runs only on a release tag, so that change is not exercised by this PR.