Repository navigation
test(AbiEvent): pin range checks for narrow indexed topic args - #589
Merged
Merged
Conversation
Co-authored-by: watarus <9610999+watarus@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a1bc8e-d1c9-702d-86cc-68140700196a Co-authored-by: jxom <jake@tempo.xyz>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 8, 2026
Contributor
|
Published pnpm add ox@pr-589
pnpm add ox@0.0.0-pr-589-bd016f9 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #588 on
main, which supersedes #502.On
main,AbiEvent.encodeaccepted out-of-range indexedintN/uintNand wrong-sizedbytesNarguments because a fast path skippedAbiParameters.encode.0.xnever had that fast path: every indexed primitive already goes throughAbiParameters.encode, so it already rejects these values. I checkedint8 128/-129,uint8 256,bytes4with 5 or 2 bytes, andbytes32with 2 or 31 bytes; all of them throw.This PR adds only the regression tests from #588, so a later backport of the fast path can't bring the bug to
0.x. There's no behavior change, so there's no changeset.Checks
AbiEvent.test.tsandAbiParameters.test.ts: 107 passed, with the Anvil-onlybehavior: networkcases excluded. The inline snapshots matchmainexactly.tsc --noEmitandbiome checkon the test file pass.