Skip to content
This repository was archived by the owner on Aug 8, 2019. It is now read-only.
This repository was archived by the owner on Aug 8, 2019. It is now read-only.

Update docs for NoErrorsPlugin deprecation and rename to NoEmitOnErrorsPlugin #96

Open

Description

@zachlysobey

The NoErrorsPlugin was deprecated in webpack PR#3570 and renamed to NoEmitOnErrorsPlugin

The docs here should probably be updated to reflect that.

Activity

  1. BrainCrumbz commented on Mar 1, 2017

    @BrainCrumbz

    Does this still apply, now that Doc github repo moved? There seems to be no reference to none of the two in https://webpack.js.org/configuration/plugins/, nor in https://github.com/webpack/webpack.js.org/tree/master/content/plugins

  2. zachlysobey commented on Mar 1, 2017

    @zachlysobey
    Author

    @BrainCrumbz I'm not really clear on where any docs have moved, or what the plan is moving forward,... but the docs I linked to still exist, and are still incomplete/misleading. If these are not the current docs, then I would guess that they should be removed, and replaced with a redirect or a link to the current documentation.

  3. BrainCrumbz commented on Mar 1, 2017

    @BrainCrumbz

    Did you check this project home? The big prints says that they moved to https://github.com/webpack/webpack.js.org, that changes here should be done on local wiki, but then again it says to submit issues/PRs at the new repo.

    So I guess a good move could be to either apply the change directly to wiki plugin list or move this issue to the new repo.

    Just sayin'...

  4. tiendq commented on Apr 21, 2017

    @tiendq

    I also used NoErrorsPlugin in an old project, just check plugins page and still don't see NoEmitOnErrorsPlugin there 👎

  5. jwineman commented on Mar 6, 2018

    @jwineman
  6. mernstackman commented on Mar 1, 2019

    @mernstackman

    I see it on VSCode is already deprecated too and there is suggestion to use config.optimization.noEmitOnErrors

  7. devinrhode2 commented on Mar 5, 2019

    @devinrhode2

    So I tried optimization.noEmitOnErrors, but optimization is not a valid configuration key for webpack THREE - so I renamed the plugin from:

        plugins: [
            new webpack.NoErrorsPlugin(),
    

    to:

        plugins: [
            new webpack.NoEmitOnErrorsPlugin(),
    

    The deprecation warning is gone, so I guess handling this for webpack3 is as easy as just renaming the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions