Add support for aliases regex matching #2

Activity

1. sokra commented on Feb 13, 2014

   

   sokra

   on Feb 13, 2014

   Member

   More actions

   Currently loaders are matched against the resolved resource.

   So you could write it less verbose with:

       module: {
         loaders: [{ test: require.resolve('angular/angular'), loader: 'exports?angular'}]
       }

   It may be possible to match against the resolved and non-resolved resource...
2. gunta commented on Feb 14, 2014

   

   gunta

   on Feb 14, 2014

   ContributorAuthor

   More actions

   I see.

   Some questions:

   1. While require.resolve works for npm packages, how would you resolve it easily for bower packages? Maybe by creating a resolve.anything() function?
   2. I think that test should match resolved, non-resolved, and aliases by default, what do you think?

   If the syntax becomes messy, perhaps using different keys? Something like:

   For aliases:

   module: {
       loaders: [{ testAlias: 'angular', loader: 'exports?angular'}]
   }

   For non-resolved resources:

   module: {
       loaders: [{ testBefore: 'angular', loader: 'exports?angular'}]
   }

   However I think something more simple like being based on the parameter type like this can be easier to use:

   For resolved resources, a Regex pattern:

   module: {
       loaders: [{ test: /angular\.js/, loader: 'exports?angular'}]
   }

   For non-resolved resources and aliases, a plain String:

   module: {
       loaders: [{ test: 'angular', loader: 'exports?angular'}]
   }

   What do you think?
3. sokra commented on Feb 14, 2014

   

   sokra

   on Feb 14, 2014

   Member

   More actions

   1. require.resolve also works for bower packages if you confiugure the resolving in your configuration to resolve them.
   2. I like the syntax which uses an alternative key for non-resolved matching. i. e. testBefore or testRaw

   strings already have a function. They match the start of the request, so you can pass an absolute path here.
4. sokra commented on Feb 14, 2014

   

   sokra

   on Feb 14, 2014

   Member

   More actions

   Oh I missunderstood part 1.

   require.resolve in the configuration only resolve npm modules. For other packages you can pass an absolute path to the package. path.join(__dirname, "bower_modules", "myPackage") or write your own resolve function which does this for you (better readable).