Skip to content

WTEL-8709: order enum columns by sort_order - #545

Open
casual-dev1234 wants to merge 4 commits into
mainfrom
fix/WTEL-8709/localized-sort-order
Open

casual-dev1234 wants to merge 4 commits into
mainfrom
fix/WTEL-8709/localized-sort-order

Conversation

@casual-dev1234

Copy link
Copy Markdown
Contributor

List endpoints accept sort_order (raw enum codes in UI-locale order) and order rows by position in it; trigger job state names map to stored codes.

List endpoints accept sort_order (raw enum codes in UI-locale order) and order rows by position in it; trigger job state names map to stored codes.
@webitel-review

webitel-review Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Webitel Code Review

Додано нове поле sort_order (SortOrder) та відповідні геттери GetSortOrder() до запитів пошуку у згенерованих файлах Protobuf (SearchRoutingSchemaRequest, SearchAgentStatusStatisticRequest, SearchAgentStateHistoryRequest, SearchAgentInQueueRequest, SearchAgentRequest). Зміни є зворотньо сумісними та мають мінімальний ризик.

📋 Walkthrough (2 файл(и/ів))
Файл Зміни
gen/engine/acr_routing_schema.pb.go Додано поле sort_order та геттер GetSortOrder() до SearchRoutingSchemaRequest.
gen/engine/agent.pb.go Додано поле sort_order та геттери GetSortOrder() до структур SearchAgentStatusStatisticRequest, SearchAgentStateHistoryRequest, SearchAgentInQueueRequest та SearchAgentRequest.

Суттєвих зауважень немає. 👍


Index-grounded review across the Webitel codebase. Знахідки можуть бути неточними — перевіряйте перед застосуванням.

…ed-sort-order

# Conflicts:
#	gen/engine/agent.pb.go
#	gen/engine/member.pb.go
#	store/sqlstore/cc_member_store.go
User sort is always quoted (raw ORDER BY only for constant defaults and store-built expressions via RawSort); scheme variables/versions drop unknown fields instead of selecting them raw.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants