Repository navigation
Per-value legend patch shapes, smaller saved maps, legend stacking above map controls - #236
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smaller saved maps
Two widget dependencies used
src: "htmlwidgets", so every saved map copied the package's whole widget folder twice, and three terra-draw dependencies shared one folder and copied it three times. Each dependency now ships only its own folder underlib/.Measured with
saveWidget(selfcontained = FALSE)on a bare map: the dependency folder drops from 14 MB to 3.3 MB formaplibre()and from 12 MB to 1.7 MB formapboxgl(). A new test checks that no dependency ships the wholehtmlwidgetsfolder or shares a folder with another.Legends
patch_shapeper value (built-in names, SVG strings, or sf objects in a list), in bothadd_categorical_legend()and compare legends.margin_*on the first legend in a corner now moves the whole stacked group, rather than taking that legend out of the stack.fill="none"andtransparentwhen recolored, so hollow shapes stay hollow.Testing
test-legend-patch-shapes.Randtest-dependency-folders.R.