Repository navigation
websocket ip in jupyter notebook #40
Description
Activity
OK, I found this has been solved in b3e46e4, the true problem I encounter is that pip hasn't update, lol
However, I'm wondering whether https://github.com/vpython/vpython-jupyter/blob/master/vpython/vpython_libraries/glowcomm.html#L61 is necessary.
However, I'm wondering whether https://github.com/vpython/vpython-jupyter/blob/master/vpython/vpython_libraries/glowcomm.html#L61 is necessary.
It seems like it shouldn't be necessary when connecting via proxy but I'm not all that familiar with the JS part of the code.
@jcoady -- do you have any comments on this?
- Hi Matt I only added support for websockets to a remote host in vpython when running in a Jupyter Notebook such as when running on MyBinder or a JupyterHub. So I only made changes to glowcomm.js file and not to glowcomm.html file. The glowcomm.html file is only used for no_notebook vpython such as when running using IDLE or Spyder. I think when running using IDLE or Spyder you are only running the python kernel on a local machine and not a remote host and so when setting up a websocket connection in this case we make the connection to a localhost. John From: "Matt Craig" <notifications@github.com> To: "vpython/vpython-jupyter" <vpython-jupyter@noreply.github.com> Cc: "johncoady" <johncoady@shaw.ca>, "Mention" <mention@noreply.github.com> Sent: Wednesday, January 1, 2020 10:11:07 AM Subject: Re: [vpython/vpython-jupyter] websocket ip in jupyter notebook (#40) However, I'm wondering whether [ https://github.com/vpython/vpython-jupyter/blob/master/vpython/vpython_libraries/glowcomm.html#L61 | https://github.com/vpython/vpython-jupyter/blob/master/vpython/vpython_libraries/glowcomm.html#L61 ] is necessary. It seems like it shouldn't be necessary when connecting via proxy but I'm not all that familiar with the JS part of the code. [ https://github.com/jcoady | @jcoady ] -- do you have any comments on this? — You are receiving this because you were mentioned. Reply to this email directly, [ #40?email_source=notifications&email_token=AAD4LZNS7235FJD5TUZGP5DQ3TMDXA5CNFSM4JUYGKWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5JZNI#issuecomment-570072245 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AAD4LZKMBZTJM2HCMNGXSLLQ3TMDXANCNFSM4JUYGKWA | unsubscribe ] .
As we know ,we might be able to make jupyter notebook listen on different ip. However, vpython always try to connect to ws://localhost.
I think that It might be well to make vpython connect to what jupyter notebook is listening on.