Skip to content

Compare primitive values with RowFn - #9978

Closed
connortsui20 wants to merge 1 commit into
developfrom
ct/row-fn-compare-primitive
Closed

connortsui20 wants to merge 1 commit into
developfrom
ct/row-fn-compare-primitive

Conversation

@connortsui20

Copy link
Copy Markdown
Member

Summary

Moves primitive comparisons onto RowFn so decoding, constants, validity, and packed Boolean output use the shared row executor.

Changes

PrimitiveCompare dispatches primitive types and comparison operators through multiversioned RowVisitor::visit_bool, replacing the primitive lane kernels and their operand wrapper. Float comparisons retain Vortex's total ordering.

The RowFn Boolean collector currently uses the default allocator, so this path does not preserve the custom allocator support added to the old primitive kernels. Tests and benchmarks have not been rerun for this rebase.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/performance A performance improvement label Sep 22, 2026
@connortsui20
connortsui20 force-pushed the ct/row-fn-compare-primitive branch from d7f1683 to 28d9dd8 Compare September 22, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant