Skip to content

Avoid allocating Vec of chunks just to copy it in ChunkedArray constructor - #9922

Merged
robert3005 merged 1 commit into
developfrom
rk/new_unchecked
Nov 4, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/new_unchecked

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

We fix cases where we were passing a vec that was immediately deallocated by
passing an impl IntoIterator where possible

For other cases we add a new constructor that leverages process_results in the
caller and a size hint to avoid materialising list of items just to check the
error case

@robert3005 robert3005 added the changelog/chore A trivial change label Sep 17, 2026
@codspeed

codspeed Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 6 improved benchmarks
❌ 1 regressed benchmark
✅ 1758 untouched benchmarks
⏩ 130 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation encode_primitives[f32, (2000, 2)] 183.8 µs 211.9 µs -13.29%
⚡ CPU Simulation missing_stats[16] 92.8 µs 75.7 µs +22.57%
⚡ CPU Simulation bench_compare_varbin[(50000, 2)] 173.2 µs 143.6 µs +20.64%
⚡ CPU Simulation filter_random_by_correlated_runs[100000] 67.1 µs 57.2 µs +17.3%
⚡ CPU Simulation bench_compare_sliced_dict_varbinview[(9999, 10000)] 244.6 µs 216.5 µs +12.99%
⚡ CPU Simulation bench_compare_sliced_dict_varbinview[(1000, 10000)] 103.4 µs 92.1 µs +12.22%
⚡ CPU Simulation canonicalize[256, 32] 60.9 µs 54.5 µs +11.73%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/new_unchecked (6270442) with develop (8b01ab5)

Open in CodSpeed

Footnotes

  1. 130 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Oct 3, 2026
@robert3005 robert3005 removed the stale This PR is stale and will be auto-closed soon label Oct 3, 2026
@robert3005
robert3005 force-pushed the rk/new_unchecked branch 2 times, most recently from 623fab0 to 829d895 Compare October 9, 2026 11:49
@robert3005
robert3005 enabled auto-merge (squash) October 9, 2026 11:49
@robert3005
robert3005 force-pushed the rk/new_unchecked branch 2 times, most recently from a4578df to da31077 Compare October 26, 2026 10:34
@robert3005
robert3005 force-pushed the rk/new_unchecked branch 2 times, most recently from 300fd4b to 4da3d17 Compare October 29, 2026 15:47
…uctor

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 merged commit 8863f85 into develop Nov 4, 2026
69 of 70 checks passed
@robert3005
robert3005 deleted the rk/new_unchecked branch November 4, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants