Repository navigation
Avoid allocating Vec of chunks just to copy it in ChunkedArray constructor - #9922
Conversation
Merging this PR will regress 1 benchmark2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
623fab0 to
829d895
Compare
a4578df to
da31077
Compare
300fd4b to
4da3d17
Compare
…uctor Signed-off-by: Robert Kruszewski <github@robertk.io>
4da3d17 to
6270442
Compare
We fix cases where we were passing a vec that was immediately deallocated by
passing an impl IntoIterator where possible
For other cases we add a new constructor that leverages process_results in the
caller and a size hint to avoid materialising list of items just to check the
error case