Repository navigation
Support filters with limit in ScanBuilder - #8766
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Reviving #7565. Scans previously rejected combining a filter with a limit. This change lets callers push the limit into Vortex and stop after enough matching rows have been produced.
What changes are included in this PR?
ScanBuilder::mapand the generic result types, applying the mapper to trimmed arrays.What APIs are changed? Are there any user-facing changes?
ScanBuilder::with_limitnow supports scans with filters.ScanBuilder::mapandScanBuilder::buildremain available.buildandRepeatedScan::executereject limits because independently scheduled split futures cannot coordinate them.Validation
Regression coverage includes filtered limits, ordering, shared budgets, sparse selections, error termination, and task construction. Tests and formatting were not run during this review revision, following repository guidance.