Skip to content

Apply top-level limit in VortexSource - #8765

Closed
AdamGS wants to merge 1 commit into
developfrom
adamg/apply-limit-vortex-source
Closed

AdamGS wants to merge 1 commit into
developfrom
adamg/apply-limit-vortex-source

Conversation

@AdamGS

@AdamGS AdamGS commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

Applies the query provided limit into the stream returned by VortexSource.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS added changelog/chore A trivial change ext/datafusion Relates to the DataFusion integration labels Jul 15, 2026

@robert3005 robert3005 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this at the scan level so it applies everywhere?

@AdamGS

AdamGS commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

I've tried in the past and complexity just shot up, I don't remember what my exact conclusion was but I think that it basically required some bigger changes and I always punted it because some bigger rewrite was around the corner.

@AdamGS

AdamGS commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor Author

I have at least 4 closed PRs around this 😅 but looking back #7565 isn't that big, I'll try and revive it.

@robert3005

Copy link
Copy Markdown
Contributor

I am asking because we need it in python as well and I don’t think it should be that hard anymore or maybe we need to try a bit harder

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Jul 30, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions Bot closed this Aug 6, 2026
@robert3005
robert3005 deleted the adamg/apply-limit-vortex-source branch October 16, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change ext/datafusion Relates to the DataFusion integration stale This PR is stale and will be auto-closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants