Skip to content

fix: struct array must skip its validity child - #3445

Merged
delta003 merged 2 commits into
developfrom
dk/fix-vortex-struct-layout-reading
Jun 4, 2025
Merged

delta003 merged 2 commits into
developfrom
dk/fix-vortex-struct-layout-reading

Conversation

@danking

@danking danking commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the changelog/fix A bug fix label Jun 3, 2025
@danking
danking force-pushed the dk/fix-vortex-struct-layout-reading branch from c924952 to 9a94b98 Compare June 3, 2025 21:26
@danking danking changed the title fix: struct layout must skip its validity child fix: struct array must skip its validity child Jun 3, 2025
@danking
danking force-pushed the dk/fix-vortex-struct-layout-reading branch 2 times, most recently from 7af6e53 to 64e7018 Compare June 3, 2025 22:01
danking added 2 commits June 3, 2025 18:43
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking
danking force-pushed the dk/fix-vortex-struct-layout-reading branch from caece8c to 255e87e Compare June 3, 2025 22:43
@danking
danking requested a review from robert3005 June 3, 2025 22:43
@delta003
delta003 merged commit 317b7ff into develop Jun 4, 2025
@delta003
delta003 deleted the dk/fix-vortex-struct-layout-reading branch June 4, 2025 09:11
@robert3005

Copy link
Copy Markdown
Contributor

This was a silly bug, we never exercise serde for struct since we have a layout for it

@gatesn

gatesn commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

We do, but only in the stats table. So makes sense the bugs kept showing up there

mwlon pushed a commit to mwlon/vortex that referenced this pull request Jun 9, 2025
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants