Repository navigation
fix: struct array must skip its validity child - #3445
Merged
Merged
Conversation
danking
force-pushed
the
dk/fix-vortex-struct-layout-reading
branch
from
June 3, 2025 21:26
c924952 to
9a94b98
Compare
danking
force-pushed
the
dk/fix-vortex-struct-layout-reading
branch
2 times, most recently
from
June 3, 2025 22:01
7af6e53 to
64e7018
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
danking
force-pushed
the
dk/fix-vortex-struct-layout-reading
branch
from
June 3, 2025 22:43
caece8c to
255e87e
Compare
delta003
approved these changes
Jun 4, 2025
Contributor
|
This was a silly bug, we never exercise serde for struct since we have a layout for it |
Contributor
|
We do, but only in the stats table. So makes sense the bugs kept showing up there |
mwlon
pushed a commit
to mwlon/vortex
that referenced
this pull request
Jun 9, 2025
Signed-off-by: Daniel King <dan@spiraldb.com> Signed-off-by: mwlon <m.w.loncaric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.