Repository navigation
Conversation
Scans in vortex-scan need the row budget that layout scans share, so the budget and the stream adapter that trims to it move down a crate and vortex-layout uses them from there. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9062
Moves
RowLimitandlimit_rowsfromvortex-layoutinto a newvortex_scan::limitmodule, so that a scan invortex-scancan enforce one limit across every clone of its stream.vortex-layoutre-exports the type instead of keeping its own copy.RowLimitis one cloneable budget: every worker takes rows from it, so together they return at most the limit.limit_rowstrims a stream to the rows it is granted and drops upstream work once the budget is spent. The code and its tests are unchanged.This PR is one layer of experiment A, which tests one decision about the Scan API: whether
DataSourceScan::open(), a cloneable asyncScanStreamthat each host thread polls, is enough for the V2 scan engine, or whether a host needs V2's synchronous step. The stack puts the V2 engine behindopen()and moves DuckDB's V2 scan onto it. The gate is DuckDB V2 on TPC-H and ClickBench within noise of develop's DuckDB V2, measured on the last layer with rotated runs. If V2 cannot reach parity through the stream, the experiment stops and reports what the engine needs thatScanStreamcannot express, with profile evidence, rather than tuning around it.Stacked on #11664
🤖 Generated with Claude Code