Repository navigation
Conversation
VortexFile::data_source now returns the plan data source, so Scan API hosts such as the Java bindings read files on the V2 scan. Files with a list layout, which the V2 scan cannot read yet, still scan on the layout reader; layout_reader_data_source keeps that path reachable for every file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
…urce Signed-off-by: Nicholas Gates <nick@nickgates.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour change:
VortexFile::data_source()returns the file's plan data source, so Scan API hosts that call it read the file on the V2 scan. Today those callers are JNI's file scan and DataFusion's V2 tests.Files with a list layout still scan on the layout reader, because the V2 scan cannot read list layouts yet.
planned_scan_supportedwalks the layout tree only when the dtype could hold a list layout.layout_reader_data_sourcekeeps the layout-reader path reachable for every file.Benchmarks: pending. This changes a default path, so the PR stays a draft until a table comparing V2 through
openwith the layout reader is posted here.Stacked on #11704.
🤖 Generated with Claude Code