Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will improve performance by 20.86%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
encodings/sparse/benches/sparse_dict_codes.rs, which canonicalizesDict(Sparse(positions, codes, NULL), values)over 65,536 rows with a 1,000-entry dictionary. It covers two value types (i64and UTF-8) at two patch densities: one present row in 100, and one in 10. The array is built unoptimized, as a reader produces it, so the measurement includes whatever path execution picks for combining the dictionary with its sparse codes. This is the shape a dictionary-encoded column takes when most of its rows are null, and #11174 optimizes exactly this path. The benchmark lands separately so that CodSpeed has a baseline for #11174.For review: the sparse codes are nullable
u16, matching the null fill. The bench count inscripts/codspeed_bench_counts.jsonis 4, one per(value type, density)case.CodSpeed reports the four benchmarks as new. Its one other change,
bitpack_compare_sweep::compare[1], is in a crate this PR does not touch.canonicalize_dict_sparse_codes_primitive[100]canonicalize_dict_sparse_codes_primitive[10]canonicalize_dict_sparse_codes_utf8[100]canonicalize_dict_sparse_codes_utf8[10]🤖 Generated with Claude Code