Repository navigation
Stop RunEnd pushdown from failing on unused runs - #11690
Draft
connortsui20 wants to merge 1 commit into
Draft
connortsui20 wants to merge 1 commit into
connortsui20 wants to merge 1 commit into
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/runend-unreferenced-runs
branch
from
November 20, 2026 17:05
00afb38 to
8ab5dfe
Compare
connortsui20
marked this pull request as ready for review
November 20, 2026 17:16
Merging this PR will degrade performance by 29.94%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
This was referenced Nov 20, 2026
connortsui20
marked this pull request as draft
November 20, 2026 19:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunEndpushes a cast or a scalar function into itsvalues, so it runs on every run, including runs that the offset and length skip. A cast or function that can fail then fails on a value that no row exposes. For example,checked_addon ani8column fails on a hidden127, and a cast to non-nullable fails on a hidden null run.Reduce rules have no execution context, so they can't search the ends for the visible runs. They push down a cast or function that can fail only when cached statistics of the ends prove that every run is visible. Otherwise a new
RunEndcast kernel trims the runs at execution time, and other functions execute on the decoded array.When the ends have no cached min and max, a function that can fail over a
RunEndcolumn no longer pushes down into the runs. Casts that can't fail, such as a lossless widening, still push down.Prepared with AI assistance.