Repository navigation
Write patch chunk offsets for ALP-RD arrays - #11644
Merged
0ax1 merged 1 commit intoNov 20, 2026
Merged
Conversation
The ALP-RD encoder now records the first patch of each 1024-row chunk, and the deserializer reads those offsets back, so readers such as the CUDA patch loader can find a chunk's patches without scanning the rest. Files written before this have no offsets and still read as before. Signed-off-by: Vishal Kotak <22182951+vishalkotak@users.noreply.github.com>
vishalkotak
force-pushed
the
vishalkotak/alp-rd-chunk-offsets
branch
from
November 19, 2026 17:04
8fed597 to
fc17253
Compare
0ax1
self-requested a review
November 20, 2026 10:36
joseph-isaacs
marked this pull request as ready for review
November 20, 2026 11:54
0ax1
approved these changes
Nov 20, 2026
0ax1
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thank you for the contribution!
Contributor
Author
|
Thanks for the quick turnaround, appreciate it. |
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11516
This is the first step toward an ALP-RD GPU kernel, as @0ax1 suggested on the issue. The CUDA patch loader needs
chunk_offsetsto find a chunk's patches in constant time, but the ALP-RD encoder never wrote them, and the deserializer dropped them on read. Both spots had aTODO(0ax1).New ALP-RD files now carry one extra child holding the offsets. The compressor narrows it, so it's 16 bytes for 16k rows in the btrblocks golden snapshot. Older files without it read the same as before, and older readers simply ignore the extra child.
Could a maintainer add the
changelog/featurelabel? I can't set labels from a fork.I used Claude Code for analysis, debugging, and ideas.