Repository navigation
Skip unused struct fields in DataFusion projection fallback - #11642
Draft
connortsui20 wants to merge 1 commit into
Draft
connortsui20 wants to merge 1 commit into
connortsui20 wants to merge 1 commit into
Conversation
A single unsupported projection makes the scan read whole struct inputs. Supply provably equivalent field reads from the scan so DataFusion can finish the enclosing expressions without reading unused siblings. Custom converters retain control of the projection split. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
added a commit
that referenced
this pull request
Nov 20, 2026
The branch carried the prototype versions of the changes that the open PRs make, and those PRs have moved on in review. For example, #11640 now names the layout `vortex.extension`. This merge takes the tree of a stack on develop at 967bcb6, which holds the PR heads and ports of the two changes that have no PR yet: - #11640 at 24fd9da. - #11710 at add4115. - #11639 at 4f25e2f. Its newer head, 115318b, fails three of its own tests. - #11642 at d16038c. - Zone maps of bounds beneath nullable structs. - Single fields of list elements on both scans. A merge instead of a force-push keeps every commit that the branch published reachable. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
develop, when a projection falls back to DataFusion, the scan reads whole input columns. This PR lets the scan read only the referenced leaves of non-nullable structs while DataFusion evaluates the original projection over those leaves.The scan reads
s.inner.labelwith its Arrow field name and metadata. DataFusion still decides which rows reach the cast, so a label of'x'on a row withid = 1is safe.Related to #11432, which runs mixed expressions inside Vortex scans. Its callback currently reads the parent struct for field access in this example.
This change was implemented and reviewed with OpenAI Codex.