Skip to content

Promote DecimalByteParts v2 and Widen to preview - #11635

Open
connortsui20 wants to merge 1 commit into
developfrom
ct/decimal-preview-edition
Open

connortsui20 wants to merge 1 commit into
developfrom
ct/decimal-preview-edition

Conversation

@connortsui20

Copy link
Copy Markdown
Member

Writers need an opt-in edition to try compressed decimals wider than 64 bits and to write explicitly constructed Widen arrays. Move both wire IDs from unstable to preview2026.11.0 so users can try them before they become part of the default writer.

Review the v2 reader changes proposed in #11442 before merging this promotion. The Decimal rollout plan tracks that decision.

@codspeed

codspeed Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 6.54%

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 1979 untouched benchmarks
⏩ 57 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime compare_u8_neon 2.1 µs 2.6 µs -17.7%
❌ Walltime compare_int_neon 4.4 µs 5 µs -10.49%
⚡ Walltime decode_avx512[DeltaU8] 11.1 µs 10 µs +10.79%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/decimal-preview-edition (3041cf4) with develop (ecff38f)2

Open in CodSpeed

Footnotes

  1. 57 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on develop (33eab03) during the generation of this report, so ecff38f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Comment thread vortex-file/src/tests.rs Resolved
Comment thread vortex/src/editions/tests.rs Resolved
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@robert3005

Copy link
Copy Markdown
Contributor

Is any audit from #11442 still required before we merge this? I know @joseph-isaacs did this for delta not sure if widen and dbpv2 got it as well.

This branch was successfully deployed

1 active deployment
vercel-docs — 3041cf4f Deployed Nov 20, 2026 by connortsui20 via Publish preview / Deploy #11449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants