Repository navigation
Move segment sources into vortex-io - #11625
Merged
Merged
Conversation
Move SegmentId, SegmentSource, SegmentLocation, the coalescing FileSegmentSource and its read driver, BufferSegmentSource and SharedSegmentSource into vortex_io::segments, so the I/O layer can read segments without depending on vortex-file or vortex-layout. The old paths re-export the moved items; behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will regress 1 benchmark1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
robert3005
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the segment types and readers into a new
vortex_io::segmentsmodule:SegmentId,SegmentSourceandSegmentLocationfrom vortex-scan, the coalescingFileSegmentSourcewith its read driver,BufferSegmentSourceandRequestMetricsfrom vortex-file, andSharedSegmentSourcefrom vortex-layout. The I/O layer can then read a file's segments itself, which #11623 needs for its session-wide scheduler, without depending on vortex-file or vortex-layout. Every item stays re-exported from its old path, and behaviour is unchanged.The only edits beyond imports:
FileSegmentSourceandBufferSegmentSourcetakeSegmentLocationinstead of vortex-file'sSegmentSpec(same fields), soFooter::segment_locations()now does the conversion thatVortexFiledid;SegmentLocation::target()becomes a private free function in vortex-scan because the type now lives in another crate; and two casts and a testcfgchange to satisfy vortex-io's stricter lints.Written with Claude Code. The vortex-io, vortex-scan, vortex-layout and vortex-file tests and clippy pass locally.
🤖 Generated with Claude Code