Skip to content

Move segment sources into vortex-io - #11625

Merged
gatesn merged 1 commit into
developfrom
ngates/scan-io-move-segments
Nov 19, 2026
Merged

gatesn merged 1 commit into
developfrom
ngates/scan-io-move-segments

Conversation

@gatesn

@gatesn gatesn commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Moves the segment types and readers into a new vortex_io::segments module: SegmentId, SegmentSource and SegmentLocation from vortex-scan, the coalescing FileSegmentSource with its read driver, BufferSegmentSource and RequestMetrics from vortex-file, and SharedSegmentSource from vortex-layout. The I/O layer can then read a file's segments itself, which #11623 needs for its session-wide scheduler, without depending on vortex-file or vortex-layout. Every item stays re-exported from its old path, and behaviour is unchanged.

The only edits beyond imports: FileSegmentSource and BufferSegmentSource take SegmentLocation instead of vortex-file's SegmentSpec (same fields), so Footer::segment_locations() now does the conversion that VortexFile did; SegmentLocation::target() becomes a private free function in vortex-scan because the type now lives in another crate; and two casts and a test cfg change to satisfy vortex-io's stricter lints.

Written with Claude Code. The vortex-io, vortex-scan, vortex-layout and vortex-file tests and clippy pass locally.

🤖 Generated with Claude Code

Move SegmentId, SegmentSource, SegmentLocation, the coalescing
FileSegmentSource and its read driver, BufferSegmentSource and
SharedSegmentSource into vortex_io::segments, so the I/O layer can read
segments without depending on vortex-file or vortex-layout. The old
paths re-export the moved items; behaviour is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/chore A trivial change label Nov 19, 2026
@gatesn
gatesn added this pull request to stack #11627 November 19, 2026 03:02
@gatesn
gatesn marked this pull request as ready for review November 19, 2026 03:02
@codspeed

codspeed Bot commented Nov 19, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚡ 10 improved benchmarks
❌ 1 regressed benchmark
✅ 1964 untouched benchmarks
⏩ 53 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation compare[1] 48.4 µs 58 µs -16.66%
⚡ Walltime compare_u8_neon 2.9 µs 1.6 µs +76.74%
⚡ Walltime compare_int_nullable_neon 5.8 µs 4.2 µs +37.85%
⚡ Walltime compare_int_constant_neon 4.3 µs 3.2 µs +33.89%
⚡ Walltime compare_int_eq_neon 5.1 µs 3.9 µs +32.92%
⚡ Walltime compare_f32_neon 5.4 µs 4.2 µs +31.01%
⚡ Walltime compare_int_neon 5.1 µs 3.9 µs +30.65%
⚡ Walltime compare_u64_neon 5 µs 3.9 µs +26.23%
⚡ Walltime scalar_subtract_neon 14.4 µs 12.3 µs +17.57%
⚡ Walltime compare_float_neon 6.9 µs 6 µs +15.67%
⚡ Walltime mul_u16_nonnull_neon 20 µs 17.7 µs +13.16%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/scan-io-move-segments (66012dd) with develop (22b7d97)

Open in CodSpeed

Footnotes

  1. 53 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@gatesn
gatesn merged commit d368834 into develop Nov 19, 2026
155 of 156 checks passed
@gatesn
gatesn deleted the ngates/scan-io-move-segments branch November 19, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants