Skip to content

Move patch take search logic out of type dispatch - #11608

Merged
connortsui20 merged 1 commit into
developfrom
ct/patches-take-search-dispatch
Nov 18, 2026
Merged

connortsui20 merged 1 commit into
developfrom
ct/patches-take-search-dispatch

Conversation

@connortsui20

@connortsui20 connortsui20 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

cargo-mutants skips macro bodies, which hides the choice between chunked and flat patch searches. Generic helpers expose that decision and the flat search’s offset handling to mutation testing.

Follow-up to #11605.
Stacked on #11607.

Prepared and opened with Codex.

@connortsui20 connortsui20 added the changelog/chore A trivial change label Nov 18, 2026 — with ChatGPT Codex Connector
@connortsui20 connortsui20 self-assigned this Nov 18, 2026
@connortsui20
connortsui20 enabled stacked auto-merge (squash) November 18, 2026 19:03
@connortsui20
connortsui20 force-pushed the ct/patches-take-search-dispatch branch from 9cd71be to 7087413 Compare November 18, 2026 19:04
@connortsui20
connortsui20 disabled stacked auto-merge November 18, 2026 19:04
@connortsui20
connortsui20 changed the base branch from develop to ct/varbin-utf8-dispatch November 18, 2026 19:04
@connortsui20
connortsui20 force-pushed the ct/patches-take-search-dispatch branch from 7087413 to 2232d40 Compare November 18, 2026 19:39
@connortsui20
connortsui20 enabled stacked auto-merge (squash) November 18, 2026 19:39
@codspeed

codspeed Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 3 regressed benchmarks
✅ 1971 untouched benchmarks
⏩ 53 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation filter_random_by_random[10000] 6.1 µs 6.9 µs -11.8%
❌ CPU Simulation density_sweep_dense_runs[0.9] 68.4 µs 77.4 µs -11.65%
❌ CPU Simulation filter_powerlaw_by_mostly_true[100000] 74 µs 83.7 µs -11.52%
⚡ CPU Simulation ArrowExportVTable_to_arrow_field 44.4 µs 16.7 µs ×2.7

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/patches-take-search-dispatch (dc3d8b7) with develop (972dbb7)

Open in CodSpeed

Footnotes

  1. 53 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@connortsui20
connortsui20 disabled stacked auto-merge November 18, 2026 20:21
Base automatically changed from ct/varbin-utf8-dispatch to develop November 18, 2026 20:22
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 force-pushed the ct/patches-take-search-dispatch branch from 2232d40 to dc3d8b7 Compare November 18, 2026 20:22
@connortsui20
connortsui20 enabled stacked auto-merge (squash) November 18, 2026 20:22
@connortsui20
connortsui20 merged commit 47e5722 into develop Nov 18, 2026
73 of 74 checks passed
@connortsui20
connortsui20 deleted the ct/patches-take-search-dispatch branch November 18, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants