Repository navigation
Check claims in the extension conformance harness - #11604
Draft
connortsui20 wants to merge 3 commits into
Draft
connortsui20 wants to merge 3 commits into
connortsui20 wants to merge 3 commits into
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/ext-claim-conformance
branch
2 times, most recently
from
November 18, 2026 18:21
b6e305c to
c573ef6
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/ext-claim-checks
branch
from
November 18, 2026 20:58
3c81806 to
96e7ef0
Compare
connortsui20
force-pushed
the
ct/ext-claim-conformance
branch
from
November 18, 2026 20:58
c573ef6 to
07f4b2a
Compare
This was referenced Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dtype constructor can only check that the storage dtype holds each declared claim. It can't tell whether a claim is true, for example when the storage orders two values differently from the values themselves. The conformance harness now takes a reference order from the caller and compares every pair of fixture values against it, which catches a claim that the storage doesn't keep.
Stacked on #11600. The diff also includes the validation harness from #11601 that this builds on.
AI assisted with this change.