Repository navigation
Add BufferMut::fill_where to fill the set positions of a bitmap - #11598
Merged
Merged
Conversation
connortsui20
force-pushed
the
ct/buffer-fill-where
branch
3 times, most recently
from
November 18, 2026 15:12
6884e46 to
d6bf17f
Compare
connortsui20
marked this pull request as ready for review
November 18, 2026 15:46
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
connortsui20
force-pushed
the
ct/buffer-fill-where
branch
from
November 18, 2026 15:57
d6bf17f to
2ceb746
Compare
robert3005
reviewed
Nov 18, 2026
robert3005
approved these changes
Nov 18, 2026
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/buffer-fill-where
branch
from
November 18, 2026 16:28
2ceb746 to
2517bf5
Compare
connortsui20
enabled auto-merge (squash)
November 18, 2026 16:32
33 of 36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primitive, VarBinView, and decimal
fill_nullkernels each write one fill value at the set positions of a validity bitmap with their own loop, and a review on #11571 asked for the decimal loop to move into a function. The loop does not depend on the element type, soBufferMut::fill_whereprovides it for anyCopyelement, and the primitive and VarBinView kernels use it here. The decimal kernel switches to it after #11571 lands.fill_wherefills each run of set bits with oneslice::fill, which is the loop the VarBinView kernel already used andvarbinview_fill_nullmeasures. The primitive kernel used to write one index at a time, and no benchmark calls it directly.