Skip to content

Add BufferMut::fill_where to fill the set positions of a bitmap - #11598

Merged
connortsui20 merged 1 commit into
developfrom
ct/buffer-fill-where
Nov 18, 2026
Merged

connortsui20 merged 1 commit into
developfrom
ct/buffer-fill-where

Conversation

@connortsui20

@connortsui20 connortsui20 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

The primitive, VarBinView, and decimal fill_null kernels each write one fill value at the set positions of a validity bitmap with their own loop, and a review on #11571 asked for the decimal loop to move into a function. The loop does not depend on the element type, so BufferMut::fill_where provides it for any Copy element, and the primitive and VarBinView kernels use it here. The decimal kernel switches to it after #11571 lands.

fill_where fills each run of set bits with one slice::fill, which is the loop the VarBinView kernel already used and varbinview_fill_null measures. The primitive kernel used to write one index at a time, and no benchmark calls it directly.

@connortsui20
connortsui20 force-pushed the ct/buffer-fill-where branch 3 times, most recently from 6884e46 to d6bf17f Compare November 18, 2026 15:12
@connortsui20
connortsui20 marked this pull request as ready for review November 18, 2026 15:46
@codspeed

codspeed Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

✅ 1975 untouched benchmarks
⏩ 53 skipped benchmarks1


Comparing ct/buffer-fill-where (2517bf5) with develop (7ebd1d3)

Open in CodSpeed

Footnotes

  1. 53 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@connortsui20 connortsui20 added the changelog/chore A trivial change label Nov 18, 2026
Comment thread vortex-buffer/src/buffer_mut.rs Resolved
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 enabled auto-merge (squash) November 18, 2026 16:32
@connortsui20
connortsui20 merged commit c1de7e8 into develop Nov 18, 2026
80 checks passed
@connortsui20
connortsui20 deleted the ct/buffer-fill-where branch November 18, 2026 16:40
@connortsui20 connortsui20 mentioned this pull request Nov 18, 2026
33 of 36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants