Skip to content

bench: add a validity density sweep to filter_bool - #11588

Merged
robert3005 merged 1 commit into
developfrom
rk/filter-bool-benchmarks
Nov 19, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/filter-bool-benchmarks

Conversation

@robert3005

@robert3005 robert3005 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Add a filter_bool benchmark for validity bitmaps. Validity bitmaps are mostly set, even when the selection is random. The existing sweeps use only random source bitmaps.

  • Add density_sweep_validity at 4 densities: 0.02, 0.1, 0.5, and 0.99.

Validity bitmaps are mostly set, even when the selection is random. Add a
sweep at 4 densities over a mostly-set source bitmap, and record the new
benchmark count for the CodSpeed shard planner.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 added this pull request to stack #11589 November 18, 2026 11:56
@robert3005 robert3005 changed the title rk/filter bool benchmarks bench: add a validity density sweep to filter_bool Nov 18, 2026
@robert3005
robert3005 marked this pull request as ready for review November 18, 2026 12:08
@robert3005 robert3005 added the changelog/chore A trivial change label Nov 18, 2026
@codspeed

codspeed Bot commented Nov 18, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.16%

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1973 untouched benchmarks
🆕 4 new benchmarks
⏩ 53 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation density_sweep_random[0.02] 55.6 µs 84.7 µs -34.43%
⚡ CPU Simulation density_sweep_random[0.001] 18.9 µs 16.1 µs +17.68%
🆕 CPU Simulation density_sweep_validity[0.02] N/A 59 µs N/A
🆕 CPU Simulation density_sweep_validity[0.1] N/A 89.7 µs N/A
🆕 CPU Simulation density_sweep_validity[0.5] N/A 100.3 µs N/A
🆕 CPU Simulation density_sweep_validity[0.99] N/A 99.4 µs N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/filter-bool-benchmarks (caa2e42) with develop (e16ccdd)

Open in CodSpeed

Footnotes

  1. 53 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005
robert3005 merged commit 06e6911 into develop Nov 19, 2026
162 of 164 checks passed
@robert3005
robert3005 deleted the rk/filter-bool-benchmarks branch November 19, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants