Repository navigation
Use canonical widths in decimal compute kernels - #11573
Merged
Merged
Conversation
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 17, 2026 21:06
a98f799 to
e8220ec
Compare
This was referenced Nov 17, 2026
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 17, 2026 21:07
e8220ec to
b1038e4
Compare
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 17, 2026 21:38
b1038e4 to
7e41269
Compare
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
2 times, most recently
from
November 17, 2026 22:36
3fee585 to
dd20bd0
Compare
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 17, 2026 22:38
dd20bd0 to
af1179e
Compare
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 18, 2026 14:48
af1179e to
b4004a0
Compare
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 18, 2026 14:51
b4004a0 to
72b4e4b
Compare
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 18, 2026 15:02
72b4e4b to
e6ae079
Compare
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 18, 2026 15:48
e6ae079 to
e867f12
Compare
connortsui20
marked this pull request as ready for review
November 18, 2026 16:32
Merging this PR will improve performance by 12.25%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 18, 2026 17:04
e867f12 to
f0250c0
Compare
connortsui20
commented
Nov 18, 2026
Comment on lines
+18
to
+19
| fn decimal_values_equal<T: PartialEq>(lhs: &[T], rhs: &[T]) -> bool { | ||
| lhs == rhs |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/decimal-remove-width-workarounds
branch
from
November 18, 2026 19:03
f0250c0 to
8789792
Compare
robert3005
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two canonical decimal arrays with the same precision and scale now share an integer width. Comparisons, patching, interleave, row encoding, and builder append can read those buffers directly. Arithmetic still selects its working and result widths independently, and DecimalByteParts still converts values when splitting a high-precision decimal into integer parts.
The public
DecimalType::is_compatible_decimal_value_typehelper is removed. UseDecimalDType::canonical_values_type()to obtain the required width.This should also help with the codegen size.
Stacked on #11572