Repository navigation
Land benchmarks in their own PR before the change they measure - #11549
Merged
Merged
Conversation
A benchmark added in the same pull request as the change it measures has no baseline, so CodSpeed reports it only as new. Tell agents to split such work into a benchmark pull request into `develop` and an implementation pull request stacked on it. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBE6jGwH9sRoqTmLZFz
robert3005
approved these changes
Nov 17, 2026
joseph-isaacs
enabled auto-merge (squash)
November 17, 2026 16:59
Fold it into the Pull Requests section that develop added, and add what landing #11548 and #11545 showed: the benchmark PR must also count its benchmarks in `scripts/codspeed_bench_counts.json`, and merging the stacked change while its base is still the benchmark branch folds it into the benchmark PR. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBE6jGwH9sRoqTmLZFz
Merging this PR will improve performance by 10.86%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A benchmark added in the same PR as the change it measures has no baseline, so CodSpeed reports it only as new. This tells agents to land the benchmark first and stack the change on it. It also records two pitfalls from #11548 and #11545: the benchmark PR must register its count in
scripts/codspeed_bench_counts.json, and the stacked change must not be merged while its base is still the benchmark branch.🤖 Generated with Claude Code