Skip to content

Export selected spatial lists with unused coordinate children - #11513

Merged
connortsui20 merged 1 commit into
developfrom
ct/spatial-filtered-list-export
Nov 17, 2026
Merged

connortsui20 merged 1 commit into
developfrom
ct/spatial-filtered-list-export

Conversation

@connortsui20

@connortsui20 connortsui20 commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Filtering a nullable polygon can leave unused coordinates in valid Arrow lists. Reconstructing those lists through GeoArrow can panic because it requires the final ring offset to match the coordinate count.

Changes

The validated target already shapes the Arrow storage, so the extra GeoArrow construction is unnecessary. A standalone nullable XYM regression covers slice, take, and filter.

Source checks passed. No builds or runtime tests were run for the split.

API Changes

Valid spatial list exports with unused child coordinates no longer panic.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 merged commit f806401 into develop Nov 17, 2026
158 checks passed
@connortsui20
connortsui20 deleted the ct/spatial-filtered-list-export branch November 17, 2026 12:43
connortsui20 added a commit that referenced this pull request Nov 17, 2026
## Summary

Builds on #11513.

Round trips can pass when import and export make matching mistakes.
Independent Arrow references are needed to check each direction against
the intended extension contract.

## Changes

Generators stay in their owning crates to avoid adding plugin
dependencies to `vortex-arrow`. Generated cases replace repetitive
examples while retaining directed regressions and rejection tests.
Native values, aggregates, and tensor layouts are checked separately so
transport failures cannot hide failures in those contracts.

Variant remains excluded pending #11359.

Source checks passed. No builds or runtime tests were run for the split.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants