Repository navigation
Export selected spatial lists with unused coordinate children - #11513
Merged
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This was referenced Nov 16, 2026
connortsui20
marked this pull request as ready for review
November 16, 2026 22:07
joseph-isaacs
approved these changes
Nov 17, 2026
connortsui20
added a commit
that referenced
this pull request
Nov 17, 2026
## Summary Builds on #11513. Round trips can pass when import and export make matching mistakes. Independent Arrow references are needed to check each direction against the intended extension contract. ## Changes Generators stay in their owning crates to avoid adding plugin dependencies to `vortex-arrow`. Generated cases replace repetitive examples while retaining directed regressions and rejection tests. Native values, aggregates, and tensor layouts are checked separately so transport failures cannot hide failures in those contracts. Variant remains excluded pending #11359. Source checks passed. No builds or runtime tests were run for the split. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filtering a nullable polygon can leave unused coordinates in valid Arrow lists. Reconstructing those lists through GeoArrow can panic because it requires the final ring offset to match the coordinate count.
Changes
The validated target already shapes the Arrow storage, so the extra GeoArrow construction is unnecessary. A standalone nullable XYM regression covers slice, take, and filter.
Source checks passed. No builds or runtime tests were run for the split.
API Changes
Valid spatial list exports with unused child coordinates no longer panic.