Repository navigation
Make VortexFile::splits take a field mask and add it to the JNI bindings - #11490
Open
robert3005 wants to merge 2 commits into
Open
robert3005 wants to merge 2 commits into
robert3005 wants to merge 2 commits into
Conversation
VortexFile::splits_for returns the natural row splits of the fields in a field mask. It reads only the layouts of those fields, so it is much cheaper than splits() for a scan of a few columns of a wide file. NativeFiles.splits exposes the splits of a file behind a NativeReadable, for every column or for a list of top-level columns. An engine can then plan splits that follow the chunks of the columns that it reads. Signed-off-by: Robert Kruszewski <github@robertk.io>
There is one method now, not splits and splits_for. A caller states which fields it scans, and passes FieldMask::All for the splits of every field. Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
marked this pull request as ready for review
November 16, 2026 11:36
robert3005
enabled auto-merge (squash)
November 16, 2026 15:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A scan of a few columns of a wide file does not need the splits of every column. To find them, the reader must read the layouts of all the columns, and for a wide table that costs more than the scan saves.
Changes
VortexFile::splitsnow takes a field mask and returns the natural row splits of those fields only. Callers passFieldMask::Allfor the splits of every field. The Python bindings and the tests do that, so their behavior does not change.NativeFiles.splits(session, readable)returns the split boundaries of the file behind aNativeReadable: splitiholds rows[boundaries[i], boundaries[i + 1]).NativeFiles.splits(session, readable, columns)does the same for a list of top-level columns. Columns that the file does not hold are ignored. If the file holds none of them, the splits follow every column.