Repository navigation
Allow benchmark labels on stacked PRs - #11472
Merged
Merged
Conversation
The PR benchmark dispatcher only fired for PRs targeting develop, so labelling a stacked PR did nothing. Drop the base-branch filter. The baseline lookup already picks the newest develop commit reachable from the PR head, so a stacked PR is compared against develop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBC1KY6sxmZBh4hoUwg Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Contributor
Author
|
@robert3005 could you review this? It's a one-line change that lets Generated by Claude Code |
robert3005
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a benchmark label (
action/bench-*) to a stacked PR did nothing, becausepr-bench-dispatch.ymlonly triggered for PRs whose base branch isdevelop.Changes
branches: ["develop"]filter from thepull_requesttrigger in.github/workflows/pr-bench-dispatch.yml.The baseline needs no changes.
scripts/fetch-benchmark-baseline.pyalready picks the newest commit reachable from the PR head that has recorded results, and only develop-mode runs write to the benchmarks database. So a stacked PR is compared againstdevelop, and the comparison includes every commit in the stack below it.GitHub reads the workflow from the PR's merge commit. An existing stack picks this up only after its parent branch is rebased onto
developwith this change.Generated by Claude Code