Skip to content

Allow benchmark labels on stacked PRs - #11472

Merged
joseph-isaacs merged 1 commit into
developfrom
ji/awesome-turing-ui6cuz
Nov 15, 2026
Merged

joseph-isaacs merged 1 commit into
developfrom
ji/awesome-turing-ui6cuz

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

Summary

Adding a benchmark label (action/bench-*) to a stacked PR did nothing, because pr-bench-dispatch.yml only triggered for PRs whose base branch is develop.

Changes

  • Remove the branches: ["develop"] filter from the pull_request trigger in .github/workflows/pr-bench-dispatch.yml.

The baseline needs no changes. scripts/fetch-benchmark-baseline.py already picks the newest commit reachable from the PR head that has recorded results, and only develop-mode runs write to the benchmarks database. So a stacked PR is compared against develop, and the comparison includes every commit in the stack below it.

GitHub reads the workflow from the PR's merge commit. An existing stack picks this up only after its parent branch is rebased onto develop with this change.


Generated by Claude Code

The PR benchmark dispatcher only fired for PRs targeting develop, so
labelling a stacked PR did nothing. Drop the base-branch filter. The
baseline lookup already picks the newest develop commit reachable from
the PR head, so a stacked PR is compared against develop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UeniBC1KY6sxmZBh4hoUwg
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs
joseph-isaacs enabled auto-merge (squash) November 13, 2026 22:35

Copy link
Copy Markdown
Contributor Author

@robert3005 could you review this? It's a one-line change that lets action/bench-* labels trigger benchmarks on stacked PRs. Results are compared against the develop baseline. Auto-merge is enabled.


Generated by Claude Code

@joseph-isaacs
joseph-isaacs merged commit 2fde412 into develop Nov 15, 2026
104 of 105 checks passed
@joseph-isaacs
joseph-isaacs deleted the ji/awesome-turing-ui6cuz branch November 15, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants