Skip to content

Expose edition selection in the C and C++ APIs - #11435

Merged
robert3005 merged 2 commits into
vortex-data:developfrom
zjw1111:zjw1111/ffi-enable-edition
Nov 13, 2026
Merged

robert3005 merged 2 commits into
vortex-data:developfrom
zjw1111:zjw1111/ffi-enable-edition

Conversation

@zjw1111

@zjw1111 zjw1111 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

C and C++ writers can now select a registered edition by name before opening a writer. This lets them target older readers through the same edition-aware writer used by Java and Python. The default file sink uses the selected edition to build its write strategy and picks up the legacy zone-map support from #10805.

Codex assisted with the implementation, tests, and documentation.

Changes

  • Add vx_session_enable_edition to the C API. It returns a status code and can report a vx_error.
  • Add vortex::Session::enable_edition(std::string_view) to the C++ API. It reports failures through vortex::VortexException.
  • Document how to select an edition before opening a C or C++ writer.
  • test_enable_edition covers selecting an older core edition on a shared session and reporting an unknown edition name.
  • test_sink_writes_legacy_zone_map_for_older_edition checks that a file written through the C sink with core2025.10.0 has a vortex.stats layout.
  • The C++ session test covers a length-delimited edition name and the exception for an unknown name.

Signed-off-by: jinli.zjw <jinli.zjw@alibaba-inc.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T07:59:40.969542Z 7313578 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@robert3005 robert3005 added the changelog/feature A new feature label Nov 13, 2026
@codspeed

codspeed Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 15.04%

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

❌ 2 regressed benchmarks
✅ 1934 untouched benchmarks
⏩ 50 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime scalar_subtract_neon 11.7 µs 14.4 µs -18.52%
❌ Walltime decode_bitpacked_chunked_neon[u32, 524288] 25.9 µs 29.3 µs -11.42%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing zjw1111:zjw1111/ffi-enable-edition (faf6edc) with develop (e780b53)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Comment thread docs/specs/versioning/using-editions.md Resolved
Signed-off-by: jinli.zjw <jinli.zjw@alibaba-inc.com>
@robert3005
robert3005 merged commit 26a12a6 into vortex-data:develop Nov 13, 2026
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants