Repository navigation
Keep statpopgen's per-sample lists aligned when a sample drops fields - #11404
Conversation
A sample may drop trailing FORMAT fields (a no-call is often just ./.), and noodles yields only the fields it has, so on rows with no-calls DP, GQ, AD and the other per-sample lists came out shorter than GT and entry j stopped being sample j. Walk the record's FORMAT keys instead, so a dropped field is null. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Martin Prammer <martin@spiraldb.com>
Merging this PR will improve performance by 27.57%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
statpopgen's builder appended each sample's FORMAT fields as noodles yielded them. A sample may drop trailing fields (a no-call is often just
./.), so on rows with no-callsDP,GQ,ADand the other per-sample lists came out shorter thanGT, and entry j stopped being sample j. The builder now walks the record's FORMAT keys and takes a dropped field as null.None of the statpopgen SQL queries read these fields, but the statpopgen compression benchmark from #11043 compresses all of them, so its numbers so far come from the misaligned lists. Cached statpopgen data has to be regenerated to pick up the fix.
🤖 Generated with Claude Code