Skip to content

perf: avoid indirect fn in decimal between_unpack - #11387

Merged
robert3005 merged 1 commit into
vortex-data:developfrom
massive-com:fix-decimal-between
Nov 11, 2026
Merged

robert3005 merged 1 commit into
vortex-data:developfrom
massive-com:fix-decimal-between

Conversation

@MassivePizza

@MassivePizza MassivePizza commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Filtering on decimals took significant time, noticed when profiling.

Changes

Call the kernel in a way that does not sneakily deoptimize it, and split the kernel to avoid branching on Options.

Perf

Disassembly shows the code vectorizes now. Benched on M4 Pro:

base PR change
between_unpack::<i64> per query 740 µs 80 µs −89%
per value (~600K values) 1.25 ns 0.14 ns -89%
whole query 2436 µs 1849 µs −24%
between(x,400,401), 1 partition 2.43 ms 1.80 ms −26%
between(x,400,401), 14 partitions 1.44 ms 1.36 ms −6%

@robert3005 robert3005 added the changelog/performance A performance improvement label Nov 11, 2026
@robert3005
robert3005 enabled auto-merge (squash) November 11, 2026 13:58
Signed-off-by: Michal Piatkowski <291740709+MassivePizza@users.noreply.github.com>
auto-merge was automatically disabled November 11, 2026 14:01

Head branch was pushed to by a user without write access

@MassivePizza

Copy link
Copy Markdown
Contributor Author

I force-pushed the DCO fix.

@robert3005
robert3005 enabled auto-merge (squash) November 11, 2026 14:27
@robert3005
robert3005 merged commit 83e1e0f into vortex-data:develop Nov 11, 2026
69 checks passed
@MassivePizza
MassivePizza deleted the fix-decimal-between branch November 11, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants