Repository navigation
Give each file_stats_reader test its own session - #11381
Merged
Merged
Conversation
robert3005
marked this pull request as ready for review
November 11, 2026 00:52
robert3005
enabled auto-merge (squash)
November 11, 2026 00:53
The tests cloned one static session and called with_handle on it. Clones of a session share state, so concurrent tests overwrote each other's runtime handle and a test could drive reads with another test's runtime, failing intermittently. Build a fresh session per test and use it for every reader in the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018SWbEu3keyvDQYHhiRs87n Signed-off-by: Robert Kruszewski <robert@spiraldb.com>
robert3005
force-pushed
the
rk/file-stats-reader-session-race
branch
from
November 11, 2026 08:59
bb6afe2 to
1fe3dd7
Compare
0ax1
self-requested a review
November 11, 2026 14:40
0ax1
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
vortex-filev2::file_stats_readertests fail intermittently. For example,dynamic_proofs_refresh_before_readsfailed in a fullvortex-filelib run while checking #11332.Each test called
SESSION.clone().with_handle(handle)on one static session. Clones of aVortexSessionshare their state, andwith_handlestores the runtime handle in that shared state. Tests running at the same time therefore overwrote each other's handle, and a test could drive its reads with another test's runtime, including one that had already shut down. Some readers in these tests were also built from the staticSESSIONdirectly, not from the test's own session.