Skip to content

Give each file_stats_reader test its own session - #11381

Merged
robert3005 merged 1 commit into
developfrom
rk/file-stats-reader-session-race
Nov 11, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/file-stats-reader-session-race

Conversation

@robert3005

@robert3005 robert3005 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The vortex-file v2::file_stats_reader tests fail intermittently. For example, dynamic_proofs_refresh_before_reads failed in a full vortex-file lib run while checking #11332.

Each test called SESSION.clone().with_handle(handle) on one static session. Clones of a VortexSession share their state, and with_handle stores the runtime handle in that shared state. Tests running at the same time therefore overwrote each other's handle, and a test could drive its reads with another test's runtime, including one that had already shut down. Some readers in these tests were also built from the static SESSION directly, not from the test's own session.

@robert3005
robert3005 marked this pull request as ready for review November 11, 2026 00:52
@robert3005
robert3005 enabled auto-merge (squash) November 11, 2026 00:53
@robert3005 robert3005 added the changelog/chore A trivial change label Nov 11, 2026
The tests cloned one static session and called with_handle on it. Clones of
a session share state, so concurrent tests overwrote each other's runtime
handle and a test could drive reads with another test's runtime, failing
intermittently. Build a fresh session per test and use it for every reader in
the test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018SWbEu3keyvDQYHhiRs87n
Signed-off-by: Robert Kruszewski <robert@spiraldb.com>
@robert3005
robert3005 force-pushed the rk/file-stats-reader-session-race branch from bb6afe2 to 1fe3dd7 Compare November 11, 2026 08:59
@0ax1
0ax1 self-requested a review November 11, 2026 14:40
@robert3005
robert3005 merged commit e1ecf3c into develop Nov 11, 2026
72 checks passed
@robert3005
robert3005 deleted the rk/file-stats-reader-session-race branch November 11, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants