Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A bounded list read whose selection has holes no longer reads every element between the first and last selected list and filters afterwards. The elements read is masked to the elements the selected lists reference, so the elements reader skips the rest, whole chunks included, and the lists are rebuilt over only what was read.
Changes
select_listsandkept_elements(list/reader.rs): the element mask and the kept lists' offsets from the cropped offsets, fetched concurrently with the validity.lists_over: checks the elements read against the last offset before building the list.CountingSegmentSourcerecords the requested segment ids.list<u64>(4k × 2,500), raw, half the rowsTesting
sparse_mask_skips_element_chunks_between_selected_lists: a mask selecting the first and last list requests two element chunks.random_list_uses_match_memory: random ranges and masks over nullable lists match the in-memory result.Follow-up
list_transform's lambda body intoListLayoutelement projection #10948 pusheslist_transformbodies into the same read.