Repository navigation
Run TPC-DS SF=10 on NVMe in the PR SQL benchmarks - #11194
Merged
Merged
Conversation
Add tpcds-nvme-10 to the pr preset (action/bench-sql) at the default DataFusion/DuckDB x Parquet/Vortex targets, and to pr-full so pr stays a subset of it. Nightly keeps running it; develop does not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBBdh1yBcuLEcJ1vAUY Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
enabled auto-merge (squash)
November 4, 2026 10:21
robert3005
approved these changes
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action/bench-sqlnow runs TPC-DS SF=10 on NVMe, on DataFusion only (Parquet and Vortex). Nightly still runs all four targets, adding DuckDB on Parquet and on Vortex.DuckDB is left out of the PR runs because DuckDB on Vortex ran out of memory on q64 in 3 of the last 4 nightly runs (
could not allocate block of size 256.0 KiB (150.6 GiB/150.6 GiB used)).Expected time, from the nightly job (same machine, same iteration count, all four targets):
In the passing run, the two DataFusion targets took 1.8 min (Parquet) and 1.7 min (Vortex). With data generation and setup, the PR job should take about 4–5 minutes. That is less than existing
prjobs such as TPC-H SF=1 on S3 (about 11 min), so the overall run should not take longer.Changes
ci_matrix/catalog.py: adds aDATAFUSIONcoverage (DataFusion on Parquet and Vortex).tpcds-nvme-10uses it in theprandpr-fullpresets and keepsDEFAULTfor nightly. It is inpr-fullbecause a test requires everyprbenchmark to be inpr-full. The benchmark run on every commit todevelopdoes not change.tests/test_matrix.py: updates the expected benchmark ids for each preset, and checks thattpcds-nvme-10runs only the DataFusion targets inprandpr-full.docs/developer-guide/benchmarking.md: theaction/bench-sqldescription now lists TPC-DS SF=10 on NVMe (DataFusion only).Checks:
pytest bench-orchestrator/tests/test_matrix.py(15 passed),ruff format --checkandruff checkonbench-orchestrator.🤖 Generated with Claude Code
https://claude.ai/code/session_01UeniBBdh1yBcuLEcJ1vAUY